Skip to content

Qualcomm AI Engine Direct - Test QNN2.37 uplevel Fix #13927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Sep 9, 2025
Merged

Qualcomm AI Engine Direct - Test QNN2.37 uplevel Fix #13927

merged 26 commits into from
Sep 9, 2025
+4 −8

Conversation

winskuo-quic
Copy link
Collaborator

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13927

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 5 Unrelated Failures

As of commit aad4cc7 with merge base bf22ab7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 4, 2025 01:17 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 4, 2025 02:05 — with GitHub Actions Failure
@winskuo-quic
Copy link
Collaborator Author

winskuo-quic commented Sep 4, 2025 •
edited
Loading

Hi @cccclai,
This PR is trying to resolve the issue mentioned in: #13352
I can get the test build-benchmark-app resolved. However, there are still couple tests related to QWEN that is failing.
I also tried reverting #13352 in this PR: #13930, but these tests are still failing.

After looking at a couple of errors in CI job, it seems to be related to environment setup:
image
image

By any chance, do you know how my changes could affect these settings?

@cccclai
Copy link
Contributor

cccclai commented Sep 4, 2025 •
edited
Loading

I think some of the android perf jobs are failing in main branch already. For the screen shot, which CI job are you referring?

Oh nvm, find it

@cccclai
Copy link
Contributor

cccclai commented Sep 4, 2025

Is the PR ready to merge? I think it should be good to fix some failure

@winskuo-quic
Copy link
Collaborator Author

Is the PR ready to merge? I think it should be good to fix some failure

Yes. This PR is ready. Thanks

@winskuo-quic winskuo-quic marked this pull request as ready for review September 5, 2025 01:09
@winskuo-quic winskuo-quic mentioned this pull request Sep 5, 2025
Merged
@shoumikhin
Copy link
Contributor

@winskuo-quic seems like nightly jobs still fail on this PR?

@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 5, 2025 01:56 — with GitHub Actions Failure
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
Could you trigger the nightly CI for me. I think it requires manual triggering.

@winskuo-quic winskuo-quic marked this pull request as draft September 8, 2025 01:05
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/QNN2.37_uplevel_fix2 branch from 19a9e36 to d405bb9 Compare September 8, 2025 01:10
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/QNN2.37_uplevel_fix2 branch from d405bb9 to b6e1b40 Compare September 8, 2025 01:24
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 02:07 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 02:32 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 09:38 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 10:09 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 11:55 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 12:14 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 13:22 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 13:45 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 14:24 — with GitHub Actions Failure
@winskuo-quic winskuo-quic marked this pull request as ready for review September 8, 2025 15:16
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 8, 2025 15:38 — with GitHub Actions Failure
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
I think the issue is now fixed.
I believe there are still a couple of errors for backend-test-linux that is operator related.
I checked the error log, and it seems like it is all using dynamic shape, which is probably not related to QNN version uplevel.
Could you take a look?
Thanks

@cccclai cccclai merged commit 879e7ba into pytorch:main Sep 9, 2025
311 of 322 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
ciflow/nightly CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winskuo-quic @cccclai @shoumikhin